Adding of RSA-SHA256 signature and oauth_body_hash parameter #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 14, 2019 12:05
Author
|
Sorry for the late return, I also have limited time. As you want, I just wanted to help by decreasing the number of lint errors. Regarding the io.Reader, I will not argue but, rather than taking in strings or []byte slices, in this kind of usage, I use an io.Reader for data sources (work with every type). |
Author
|
Hi Gary, gentle reminder :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First at all, thanks for your work on this package.
The purpose of this pull request is to add the following features:
oauth_body_hashparameter in OAuth header. In order to not break the method's signature, a new one is created to manage it: SetAuthorizationHeaderWithBody.1- Fixes some golint errors.
Thanks,